[codex] fix layout engine edge case panics#32
Draft
ola-893 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes layout edge cases that could panic or collapse content unexpectedly.
Why
The layout engine had a few unsafe assumptions around optional dimensions and graph lookups. Some of those assumptions showed up as panics; others made the SplitView regression fail once re-enabled.
Impact
Layout remains deterministic, but collapsed or partially-constrained children are handled more carefully. Fixed dimensions are no longer overwritten by tight parent constraints.
Validation
cargo test -p fission-layout --locked --offline -- --nocapturecargo test -p fission-test --test interaction_and_layout_regressions test_email_list_width --locked --offline -- --nocapture